Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Suppress advertiserIDCollectionEnabledFalseWarning #1082

Closed
4 tasks done
liamnichols opened this issue Oct 16, 2019 · 9 comments
Closed
4 tasks done

Comments

@liamnichols
Copy link

Checklist

  • I've updated to the latest released version of the SDK
  • I've searched for existing feature requests on GitHub issues
  • I've read the Code of Conduct
  • I've given my issue the title: Feature Request: [name of my feature request]

Goals

As a consumer of the Facebook SDKs purely for social login purposes, I don't want to be notified about unrelated configuration warnings in the console logs during development of my application.

Since we have no need for Facebook to track analytics, we've set the FacebookAdvertiserIDCollectionEnabled and FacebookAutoLogAppEventsEnabled info plist keys to false however we now get the following log message:

<Warning>: The value for FacebookAdvertiserIDCollectionEnabled is currently set to FALSE so you're sending app events without collecting Advertiser ID. This can affect the quality of your advertising and analytics results.

Expected Results

The log message above is not printed in my console. I explicitly opted out of any kind of automatic tracking and I don't need to be reminded about it each time we build and run the application.

If you're happy for me to, I'd be more than happy to submit a PR removing it but I'll wait for a response here first. Thanks

@liamnichols
Copy link
Author

liamnichols commented Oct 16, 2019

The log states the following:

so you're sending app events

But the code in FBSDKSettings is only checking isAdvertiserIDCollectionEnabled... Its wrong to assume that I'm sending events when isAdvertiserIDCollectionEnabled is false so maybe this is a bug... Could it not just log in the event that the user tries to track an event with this disabled?

@tianqibt
Copy link
Contributor

Thanks for submitting this request. We will add it to our feature request list.

The complete sentence is so you're sending app events without collecting Advertiser ID. The flag isAdvertiserIDCollectionEnabled only controls whether you will send app events WITH advertiser id to Facebook, rather than control whether you send app events.

@hasanalbukhari
Copy link

So now in iOS 14 setAdvertiserTrackingEnabled is there. how is that difference than isAdvertiserIDCollectionEnabled?

@AndyMeagher
Copy link

Any updates on this feature request? I would like this removed from my console as well.

@JacopoDaeli
Copy link

@tianqibt my understanding is no difference. It's the same thing.

@JacopoDaeli
Copy link

But I may be wrong :)

@ghost
Copy link

ghost commented Sep 9, 2021

Thanks for submitting this request. We will add it to our feature request list.

The complete sentence is so you're sending app events without collecting Advertiser ID. The flag isAdvertiserIDCollectionEnabled only controls whether you will send app events WITH advertiser id to Facebook, rather than control whether you send app events.

It's been 2 years, feature request list definitely not effective enough to remove undesired warnings spamming the console of every app using the sdk.

Is there other way around to speed things up?

@marshall86
Copy link

any news about this matter? I'm getting that warning too. Thanks

@Pigpocket
Copy link

Still getting this warning when set to TRUE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants