This repository has been archived by the owner on Nov 2, 2019. It is now read-only.
Update for Xcode 9 and Swift 4 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The title, description, and imageURL fields are deprecated for LinkShareContent in in Graph API 2.9
Changing SWIFT_VERSION to 4.0 for FacebookCore, FacebookShare, FacebookLogin, and SwiftCatalog
Replacing deprecated usages of .toUIntMax() in AppEvent and AppInvite
Hotfix being released for the objective-c SDK to support Xcode 9 and Swift 4
This was referenced Oct 9, 2017
Updates the Xcode image used by Travis to 9
Closed
Update shields Swift badge to 4.0
Clears the warning that ReadPermission and PublishPermission both have a default case which will never be executed.
Remove redundant conformance constraints from GraphRequestConnection
Remove redundant conformance constraint from GraphAPIReadViewController
|
when will this be updated? |
Update .swift-version to 4.0
nlutsenko
approved these changes
Oct 11, 2017
|
LGTM. Please squash and merge! |
guoye-zhang
reviewed
Oct 11, 2017
| .filter({ | ||
| validCharacters.contains(UnicodeScalar(UInt16($0.value))!) | ||
| }) | ||
| .map(Character.init) |
There was a problem hiding this comment.
Old code truncates string to its first 10 characters, but this keeps its original length. Is this an expected change? If not, I suggest adding .prefix(10) here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates xcconfig files, deprecates fields in FBSDKLinkShareContent, replaces deprecated .toUIntMax behavior, and updates Cartfiles to depend on pending objective-c sdk hotfix.