Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.9.0 (non-alpha version) #217

Closed
dmnd opened this issue Jan 30, 2017 · 3 comments
Closed

Release 0.9.0 (non-alpha version) #217

dmnd opened this issue Jan 30, 2017 · 3 comments

Comments

@dmnd
Copy link

dmnd commented Jan 30, 2017

Relay is currently depending on 0.8.1 because 0.9.0 is still in alpha (and has been for 7 months).

This is a problem for Relay because it ends up depending on core-js twice (see facebook/relay#1421).

Can you please publish the current alpha as a real release?

@zpao
Copy link
Member

zpao commented Jan 31, 2017

React 15.x probably won't upgrade past fbjs 0.8.x so you won't see the benefits you're looking for in that other issue. I'll have to go back and see what has changed but I'm pretty sure there was a big difference with shallowCompare that would require React doing a major bump.

As to @wincent's question about why there's even an alpha here… I think that was to get some code into the hands of Draft, and then I haven't done a sync in a months.

We can do a sync here and land a couple other things (#165 should probably ship), but like I said, you likely won't see the benefits you want yet. Maybe we could update core-js in the 0.8 branch.

@dmnd
Copy link
Author

dmnd commented Jan 31, 2017

Releasing a non-alpha would still set things up to work nicely once React 16 ships, assuming they also bump to 0.9.0. 16 is already a major change so probably they'd be ok with updating fbjs too?

Maybe we could update core-js in the 0.8 branch.

That'd be nice in the meantime if you're up for it.

@dmnd
Copy link
Author

dmnd commented Jul 8, 2019

Closing since releases happened. Thanks!

@dmnd dmnd closed this as completed Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants