Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory issues because of usage of Object.finalize() #1354

Closed
fab1an opened this issue Jul 12, 2016 · 3 comments
Closed

Memory issues because of usage of Object.finalize() #1354

fab1an opened this issue Jul 12, 2016 · 3 comments
Labels

Comments

@fab1an
Copy link

fab1an commented Jul 12, 2016

I've reported an issue in react-native, that applies here as well: facebook/react-native#8711

@narychen
Copy link

Oh I didn't see you opened an issue already. I just opened another same issue here.

@narychen
Copy link

narychen commented Jul 14, 2016

I noticed a important clue on Fresco site.

Memory
A decompressed image - an Android Bitmap - takes up a lot of memory. This leads to more frequent runs of the Java garbage collector. This slows apps down. The problem is especially bad without the improvements to the garbage collector made in Android 5.0.
On Android 4.x and lower, Fresco puts images in a special region of Android memory. It also makes sure that images are automatically released from memory when they’re no longer shown on screen. This lets your application run faster - and suffer fewer crashes.
Apps using Fresco can run even on low-end devices without having to constantly struggle to keep their image memory footprint under control.

Which I found on my android 4.3 phone, the memory usage is very low around 20M-30M, no matter how many pictures you browse. So I think the leaks exist on the special region of Android memory, not java. And finalize is not the cause of these problems.

@fab1an
Copy link
Author

fab1an commented Jul 14, 2016

Closing in favor of #1363 .

@fab1an fab1an closed this as completed Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants