From e7ff4b4de335ae132f81d01139a93e362cbf5e99 Mon Sep 17 00:00:00 2001 From: Nicholas Ormrod Date: Wed, 5 Oct 2022 10:38:55 -0700 Subject: [PATCH] Disable benchmark tests Summary: MPMCQueue intermixes tests and benchmarks. The benchmarks, since they take a long time, are flakey. Disable them. Reviewed By: Orvid Differential Revision: D40069957 fbshipit-source-id: 91786209a6f2ff446c0f3531aa50c2e0656cf3ad --- .../folly/src/folly/test/MPMCQueueTest.cpp | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/third-party/folly/src/folly/test/MPMCQueueTest.cpp b/third-party/folly/src/folly/test/MPMCQueueTest.cpp index 39f6edabfe912..f4ae6b0e3364b 100644 --- a/third-party/folly/src/folly/test/MPMCQueueTest.cpp +++ b/third-party/folly/src/folly/test/MPMCQueueTest.cpp @@ -591,11 +591,13 @@ void runMtProdConsDeterministicDynamic( } } -TEST(MPMCQueue, mt_prod_cons_deterministic) { +// This is a benchmark, not a test +TEST(MPMCQueue, DISABLED_mt_prod_cons_deterministic) { runMtProdConsDeterministic(0); } -TEST(MPMCQueue, mt_prod_cons_deterministic_dynamic) { +// This is a benchmark, not a test +TEST(MPMCQueue, DISABLED_mt_prod_cons_deterministic_dynamic) { runMtProdConsDeterministic(0); } @@ -607,7 +609,8 @@ void setFromEnv(T& var, const char* envvar) { } } -TEST(MPMCQueue, mt_prod_cons_deterministic_dynamic_with_arguments) { +// This is a benchmark, not a test +TEST(MPMCQueue, DISABLED_mt_prod_cons_deterministic_dynamic_with_arguments) { long seed = 0; uint32_t prods = 10; uint32_t cons = 10; @@ -656,11 +659,13 @@ void runMtProdCons() { } } -TEST(MPMCQueue, mt_prod_cons) { +// This is a benchmark, not a test +TEST(MPMCQueue, DISABLED_mt_prod_cons) { runMtProdCons(); } -TEST(MPMCQueue, mt_prod_cons_dynamic) { +// This is a benchmark, not a test +TEST(MPMCQueue, DISABLED_mt_prod_cons_dynamic) { runMtProdCons(); }