Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage includes hni files for systemlib classes. #2992

Closed
whatthejeff opened this issue Jun 20, 2014 · 8 comments
Closed

Code coverage includes hni files for systemlib classes. #2992

whatthejeff opened this issue Jun 20, 2014 · 8 comments

Comments

@whatthejeff
Copy link
Contributor

<?php

fb_enable_code_coverage();

new stdClass;
new Memcached;
new ZipArchive;
new ReflectionClass('stdClass');

$data = fb_get_code_coverage(TRUE);

fb_disable_code_coverage();

var_dump($data);

Output:

array(5) {
  ["systemlib.phpreflection_hni"]=>
  array(5) {
    [969]=>
    int(1)
    [973]=>
    int(1)
    [975]=>
    int(2)
    [978]=>
    int(1)
    [989]=>
    int(1)
  }
  ["systemlib.php"]=>
  array(1) {
    [8]=>
    int(1)
  }
  ["systemlib.phpmemcached"]=>
  array(1) {
    [19]=>
    int(1)
  }
  ["/in/p94Rr"]=>
  array(6) {
    [3]=>
    int(1)
    [5]=>
    int(2)
    [6]=>
    int(2)
    [7]=>
    int(2)
    [8]=>
    int(2)
    [10]=>
    int(1)
  }
  ["systemlib.phpzip"]=>
  array(1) {
    [416]=>
    int(1)
  }
}
@goetas
Copy link
Contributor

goetas commented Jun 20, 2014

@whatthejeff thanks!

@whatthejeff
Copy link
Contributor Author

@goetas No problemo :)

@ptarjan
Copy link
Contributor

ptarjan commented Jun 20, 2014

@jlreyes is going to be implementing ACTUAL xdebug instead of our fake functions so hopefully that will be fixed in his implementation.

@paulbiss
Copy link
Contributor

paulbiss commented Sep 9, 2014

@jlreyes / @whatthejeff can we close this?

@whatthejeff
Copy link
Contributor Author

@paulbiss I'm fine with closing this if there are no plans to fix it.

@paulbiss
Copy link
Contributor

paulbiss commented Sep 9, 2014

Okay, have a look at Xdebug and feel free to open a new issue if it isn't going to do what you need it to.

@paulbiss paulbiss closed this as completed Sep 9, 2014
@whatthejeff
Copy link
Contributor Author

Will do. Thanks!

@jlreyes
Copy link
Contributor

jlreyes commented Sep 9, 2014

I actually fixed this for both xdebug and fb_enable_code_coverage() in eef0598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants