Wrong boolean behavior

[imsamurai]

Test code is:

$x =(!(strtolower('no') === 'no'));
var_dump($x);

should be false, but got true on all 3.* versions. Pure php 5.* outputs false
Tests: https://travis-ci.org/imsamurai/hhvm-test

[MaideCa]

My local master tests agree, but 3v4l disagrees (http://3v4l.org/gZ3TP).

Local script/output:

maide@sonic ~/hhvm $ cat test.php 
<?php
$x = (!(strtolower('no') === 'no'));
var_dump($x);
$x = ((strtolower('no') === 'no'));
var_dump($x);

PHP

maide@sonic ~/hhvm $ php -f test.php 
bool(false)
bool(true)

HHVM

maide@sonic ~/hhvm $ hphp/hhvm/hhvm -f test.php 
bool(true)
bool(true)

[imsamurai]

Yes it is strange that 3v4l is ok. I tested on 3 machines + travis - all results was wrong

[SiebelsTim]

Seems somehow related to strto(lower|upper)

<?php
$x = ((strtolower("no") === "no"));
var_dump($x);
$x = (!(strtolower("no") === "no"));
var_dump($x);

var_dump(!(strtolower("no") === "no"));
var_dump(((strtolower("no") === "no")));

// Everything down below works
echo "\n";

$x = (("no" === "no"));
var_dump($x);
$x = (!("no" === "no"));
var_dump($x);

var_dump(!("no" === "no"));
var_dump((("no" === "no")));

echo "\n";

$no = "no";
$no2 = "no";
var_dump(!(++$no === ++$no2));
var_dump(((++$no === ++$no2)));

[imsamurai]

no, strtolower works as expected, i add more tests

[imsamurai]

I suppose problem somewhere in code translation/optimization

[JoelMarcey]

Hmmm....

I am having trouble repoing this. At first I thought it might be a JIT vs. interp issue, but on master, both are returning false for the sample that @imsamurai provided in the initial post.

[joelm /tmp] hhvmb -v Eval.Jit=1 4007.php
bool(false)
[joelm /tmp] hhvmb -v Eval.Jit=0 4007.php
bool(false)

[SiebelsTim]

I can't reproduce this anymore.