Raise warning when put_contents on non-regular file with exclusive lock. #4238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D28827 |
In HHVM_FUNCTION(file_put_contents), raise warning if attempting to add an exclusive lock on non-regular file, in order to match PHP5's behavior. Passing vfsstream's filePutContentsLockShouldReportError test case.
kevinxucs
force-pushed
the
vfsstream-lock-error
branch
from
1dbfd2a to
1db0f56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In file_put_contents(), raise warning if attempting to add an exclusive lock on non-regular file.
Passing vfsstream's filePutContentsLockShouldReportError test case.