This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Warnings improvements #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nataliemt
commented
Apr 5, 2021
nataliemt
commented
- Display in the tab the number of warnings
- Remove duplicate warnings (message + selector)
… Remove duplicate warnings (message + selector)
pestevez
reviewed
Apr 6, 2021
There was a problem hiding this comment.
This is a great addition! I was constantly switching to the warnings tab to see if I had any of them. Thanks for adding it :)
Not a deal breaker, but would it be hard to return no warnings when the web server takes the path of an invalid IA? Right now what happens as soon as we load a web page with blank rules is that it shows a single warning, which could be deceiving.
|
@pestevez Updated the PR, so now the warnings will be listed only if it has a preview.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.