fix(jest-cli): use correct filename to override config (#10337)

jestjs · Jul 31, 2020 · 0708daf · 0708daf
1 parent 104a571
commit 0708daf
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@
 
 ### Fixes
 
+- `[jest-cli]` Use correct file name to override existing jest config on init ([#10337](https://github.com/facebook/jest/pull/10337))
+
 ### Chore & Maintenance
 
 ### Performance

diff --git a/packages/jest-cli/src/init/__tests__/init.test.js b/packages/jest-cli/src/init/__tests__/init.test.js
@@ -175,8 +175,10 @@ describe('init', () => {
 
           expect(prompts.mock.calls[0][0]).toMatchSnapshot();
 
+          const jestConfigFileName = fs.writeFileSync.mock.calls[0][0];
           const writtenJestConfig = fs.writeFileSync.mock.calls[0][1];
 
+          expect(jestConfigFileName).toBe(`jest.config.${extension}`);
           expect(writtenJestConfig).toBeDefined();
         });
 

diff --git a/packages/jest-cli/src/init/index.ts b/packages/jest-cli/src/init/index.ts
@@ -61,21 +61,21 @@ export default async (
     hasJestProperty = true;
   }
 
-  const existingJestConfigPath = JEST_CONFIG_EXT_ORDER.find(ext =>
+  const existingJestConfigExt = JEST_CONFIG_EXT_ORDER.find(ext =>
     fs.existsSync(path.join(rootDir, getConfigFilename(ext))),
   );
-  const jestConfigPath =
-    existingJestConfigPath ||
-    path.join(
-      rootDir,
-      getConfigFilename(
-        projectPackageJson.type === 'module'
-          ? JEST_CONFIG_EXT_MJS
-          : JEST_CONFIG_EXT_JS,
-      ),
-    );
-
-  if (hasJestProperty || existingJestConfigPath) {
+  const jestConfigPath = existingJestConfigExt
+    ? getConfigFilename(existingJestConfigExt)
+    : path.join(
+        rootDir,
+        getConfigFilename(
+          projectPackageJson.type === 'module'
+            ? JEST_CONFIG_EXT_MJS
+            : JEST_CONFIG_EXT_JS,
+        ),
+      );
+
+  if (hasJestProperty || existingJestConfigExt) {
     const result: {continue: boolean} = await prompts({
       initial: true,
       message: