chore: drop node 8 support (#9423)

jestjs · May 2, 2020 · 56782b9 · 56782b9
1 parent 37a9402
commit 56782b9
Show file tree

Hide file tree

Showing 61 changed files with 61 additions and 108 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -18,22 +18,6 @@ aliases:
 
 version: 2
 jobs:
-  test-node-8:
-    working_directory: ~/jest
-    docker:
-      - image: circleci/node:8
-    steps:
-      - checkout
-      - run:
-          command: yarn remove-prettier-dep
-      - restore-cache: *restore-cache
-      - run: *install
-      - save-cache: *save-cache
-      - run:
-          command: yarn test-ci-partial
-      - store_test_results:
-          path: reports/junit
-
   test-node-10:
     working_directory: ~/jest
     docker:
@@ -123,7 +107,6 @@ workflows:
   version: 2
   build-and-deploy:
     jobs:
-      - test-node-8
       - test-node-10
       - test-node-12
       - test-node-13

diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -54,8 +54,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        # https://github.com/actions/setup-node/issues/27
-        node-version: [8.17.0, 10.x, 12.x, 13.x, 14.x]
+        node-version: [10.x, 12.x, 13.x, 14.x]
         os: [ubuntu-latest, macOS-latest, windows-latest]
     runs-on: ${{ matrix.os }}
 

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@
 ### Chore & Maintenance
 
 - `[*]` [**BREAKING**] TypeScript definitions requires a minimum of TypeScript v3.8 ([#9823](https://github.com/facebook/jest/pull/9823))
+- `[*]` [**BREAKING**] Drop support for Node 8 ([#9423](https://github.com/facebook/jest/pull/9423))
 - `[jest-runtime]` [**BREAKING**] Remove long-deprecated `require.requireActual` and `require.requireMock` methods ([#9854](https://github.com/facebook/jest/pull/9854))
 - `[expect, jest-mock, pretty-format]` [**BREAKING**] Remove `build-es5` from package ([#9945](https://github.com/facebook/jest/pull/9945))
 - `[jest-haste-map]` [**BREAKING**] removed `providesModuleNodeModules` ([#8535](https://github.com/facebook/jest/pull/8535))

diff --git a/babel.config.js b/babel.config.js
@@ -40,7 +40,7 @@ module.exports = {
           },
         ],
       ],
-      test: 'packages/jest-config/src/importEsm.ts',
+      test: 'packages/jest-config/src/readConfigFileAndSetRootDir.ts',
     },
   ],
   plugins: [

diff --git a/package.json b/package.json
@@ -93,7 +93,6 @@
     "lint:prettier:ci": "prettier '**/*.{md,yml,yaml}' 'website/static/**/*.{css,js}' --check --ignore-path .gitignore",
     "postinstall": "opencollective postinstall && yarn build",
     "install-no-ts-build": "node ./scripts/remove-postinstall && yarn --no-progress --frozen-lockfile && node ./scripts/build",
-    "remove-prettier-dep": "node ./scripts/remove-prettier-dep",
     "publish": "yarn build-clean && yarn build && lerna publish --silent",
     "test-ci": "yarn jest-coverage --color -i --config jest.config.ci.js && yarn test-leak && node ./scripts/mapCoverage.js && codecov",
     "test-ci-partial": "yarn jest --color -i --config jest.config.ci.js",
@@ -132,6 +131,6 @@
     "logo": "https://opencollective.com/jest/logo.txt"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   }
 }
diff --git a/packages/babel-jest/package.json b/packages/babel-jest/package.json
@@ -28,7 +28,7 @@
     "@babel/core": "^7.0.0"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/babel-plugin-jest-hoist/package.json b/packages/babel-plugin-jest-hoist/package.json
@@ -7,7 +7,7 @@
     "directory": "packages/babel-plugin-jest-hoist"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "license": "MIT",
   "main": "build/index.js",

diff --git a/packages/babel-preset-jest/package.json b/packages/babel-preset-jest/package.json
@@ -16,7 +16,7 @@
     "@babel/core": "^7.0.0"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/diff-sequences/package.json b/packages/diff-sequences/package.json
@@ -16,7 +16,7 @@
     "diff"
   ],
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "main": "build/index.js",
   "types": "build/index.d.ts",

diff --git a/packages/eslint-config-fb-strict/package.json b/packages/eslint-config-fb-strict/package.json
@@ -20,7 +20,7 @@
     "eslint-plugin-react": "^7.1.0"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/expect/package.json b/packages/expect/package.json
@@ -24,7 +24,7 @@
     "immutable": "^4.0.0-rc.12"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/expect/src/__tests__/__snapshots__/matchers.test.js.snap b/packages/expect/src/__tests__/__snapshots__/matchers.test.js.snap
@@ -2022,11 +2022,11 @@ exports[`.toEqual() {pass: false} expect("type TypeName<T> = T extends Function
 <r>+ type TypeName<T> = T extends Function<i> </i>? "function"<i> </i>: "object";</>
 `;
 
-exports[`.toEqual() {pass: false} expect(/abc/gy).toEqual(/abc/g) 1`] = `
+exports[`.toEqual() {pass: false} expect(/abc/gsy).toEqual(/abc/g) 1`] = `
 <d>expect(</><r>received</><d>).</>toEqual<d>(</><g>expected</><d>) // deep equality</>
 
 Expected: <g>/abc/g</>
-Received: <r>/abc/gy</>
+Received: <r>/abc/gsy</>
 `;
 
 exports[`.toEqual() {pass: false} expect([1, 2]).toEqual([2, 1]) 1`] = `

diff --git a/packages/jest-changed-files/package.json b/packages/jest-changed-files/package.json
@@ -15,7 +15,7 @@
     "throat": "^5.0.0"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-circus/package.json b/packages/jest-circus/package.json
@@ -42,7 +42,7 @@
     "graceful-fs": "^4.2.4"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-cli/package.json b/packages/jest-cli/package.json
@@ -32,7 +32,7 @@
     "jest": "./bin/jest.js"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "repository": {
     "type": "git",

diff --git a/packages/jest-config/package.json b/packages/jest-config/package.json
@@ -37,7 +37,7 @@
     "@types/micromatch": "^4.0.0"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-config/src/__tests__/Defaults.test.ts b/packages/jest-config/src/__tests__/Defaults.test.ts
@@ -7,8 +7,6 @@
 
 import {defaults} from '../index';
 
-jest.mock('../importEsm', () => (s: string) => import(s));
-
 test('get configuration defaults', () => {
   expect(defaults).toBeDefined();
 });
diff --git a/packages/jest-config/src/__tests__/readConfig.test.ts b/packages/jest-config/src/__tests__/readConfig.test.ts
@@ -7,8 +7,6 @@
 
 import {readConfig} from '../index';
 
-jest.mock('../importEsm', () => (s: string) => import(s));
-
 test('readConfig() throws when an object is passed without a file path', async () => {
   await expect(
     readConfig(

diff --git a/packages/jest-config/src/__tests__/readConfigs.test.ts b/packages/jest-config/src/__tests__/readConfigs.test.ts
@@ -7,8 +7,6 @@
 
 import {readConfigs} from '../index';
 
-jest.mock('../importEsm', () => (s: string) => import(s));
-
 test('readConfigs() throws when called without project paths', async () => {
   await expect(
     // @ts-ignore

diff --git a/packages/jest-config/src/importEsm.ts b/packages/jest-config/src/importEsm.ts
diff --git a/packages/jest-config/src/readConfigFileAndSetRootDir.ts b/packages/jest-config/src/readConfigFileAndSetRootDir.ts
@@ -6,12 +6,12 @@
  */
 
 import * as path from 'path';
+import {pathToFileURL} from 'url';
 import * as fs from 'graceful-fs';
 import type {Config} from '@jest/types';
 // @ts-ignore: vendored
 import jsonlint from './vendor/jsonlint';
 import {JEST_CONFIG_EXT_JSON, PACKAGE_JSON} from './constants';
-import importEsm from './importEsm';
 
 // Read the configuration and set its `rootDir`
 // 1. If it's a `package.json` file, we look into its "jest" property
@@ -28,7 +28,10 @@ export default async function readConfigFileAndSetRootDir(
   } catch (error) {
     if (error.code === 'ERR_REQUIRE_ESM') {
       try {
-        const importedConfig = await importEsm(configPath);
+        const configUrl = pathToFileURL(configPath);
+
+        // node `import()` supports URL, but TypeScript doesn't know that
+        const importedConfig = await import(configUrl.href);
 
         if (!importedConfig.default) {
           throw new Error(

diff --git a/packages/jest-console/package.json b/packages/jest-console/package.json
@@ -20,7 +20,7 @@
     "@types/node": "*"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-core/package.json b/packages/jest-core/package.json
@@ -44,7 +44,7 @@
     "jest-snapshot-serializer-raw": "^1.1.0"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "repository": {
     "type": "git",

diff --git a/packages/jest-diff/package.json b/packages/jest-diff/package.json
@@ -20,7 +20,7 @@
     "strip-ansi": "^6.0.0"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-docblock/package.json b/packages/jest-docblock/package.json
@@ -16,7 +16,7 @@
     "@types/node": "*"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-each/package.json b/packages/jest-each/package.json
@@ -25,7 +25,7 @@
     "pretty-format": "^25.5.0"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-environment-jsdom/package.json b/packages/jest-environment-jsdom/package.json
@@ -21,7 +21,7 @@
     "@types/jsdom": "^12.2.4"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-environment-node/package.json b/packages/jest-environment-node/package.json
@@ -14,14 +14,10 @@
     "@jest/fake-timers": "^25.5.0",
     "@jest/types": "^25.5.0",
     "jest-mock": "^25.5.0",
-    "jest-util": "^25.5.0",
-    "semver": "^6.3.0"
-  },
-  "devDependencies": {
-    "@types/semver": "^6.2.1"
+    "jest-util": "^25.5.0"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-environment-node/src/index.ts b/packages/jest-environment-node/src/index.ts
@@ -14,7 +14,6 @@ import {
   LolexFakeTimers,
 } from '@jest/fake-timers';
 import type {JestEnvironment} from '@jest/environment';
-import {lt as semverLt} from 'semver';
 
 type Timer = {
   id: number;
@@ -122,11 +121,4 @@ class NodeEnvironment implements JestEnvironment {
   }
 }
 
-// node 10 had a bug in `vm.compileFunction` that was fixed in https://github.com/nodejs/node/pull/23206.
-// Let's just pretend the env doesn't support the function.
-// Make sure engine requirement is high enough when we drop node 8 so we can remove this condition
-if (semverLt(process.version, '10.14.2')) {
-  delete NodeEnvironment.prototype.getVmContext;
-}
-
 export = NodeEnvironment;
diff --git a/packages/jest-environment/package.json b/packages/jest-environment/package.json
@@ -18,7 +18,7 @@
     "@types/node": "*"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-fake-timers/package.json b/packages/jest-fake-timers/package.json
@@ -21,7 +21,7 @@
     "@types/node": "*"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-get-type/package.json b/packages/jest-get-type/package.json
@@ -8,7 +8,7 @@
     "directory": "packages/jest-get-type"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "license": "MIT",
   "main": "build/index.js",

diff --git a/packages/jest-globals/package.json b/packages/jest-globals/package.json
@@ -7,7 +7,7 @@
     "directory": "packages/jest-globals"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "license": "MIT",
   "main": "build/index.js",

diff --git a/packages/jest-haste-map/package.json b/packages/jest-haste-map/package.json
@@ -36,7 +36,7 @@
     "fsevents": "^2.1.2"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-jasmine2/package.json b/packages/jest-jasmine2/package.json
@@ -33,7 +33,7 @@
     "@types/co": "^4.6.2"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-leak-detector/package.json b/packages/jest-leak-detector/package.json
@@ -18,7 +18,7 @@
     "weak-napi": "^1.0.3"
   },
   "engines": {
-    "node": ">= 8.3"
+    "node": ">= 10.14.2"
   },
   "publishConfig": {
     "access": "public"
-Original file line number
+Diff line change
@@ Expand Up / @@ -40,7 +40,7 @@ module.exports = { @@
               },
             ],
           ],
-          test: 'packages/jest-config/src/importEsm.ts',
+          test: 'packages/jest-config/src/readConfigFileAndSetRootDir.ts',
         },
       ],
       plugins: [
@@ Expand Down @@