Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(gettingStarted): add Yarn install #3588

Merged
merged 2 commits into from
May 17, 2017
Merged

docs(gettingStarted): add Yarn install #3588

merged 2 commits into from
May 17, 2017

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented May 17, 2017

cc @cpojer
Summary

The instructions for installing via Yarn are slightly different than with npm. This meanwhile also gives a backlink to the detail page on Yarn, as discussed

@codecov-io
Copy link

Codecov Report

Merging #3588 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3588   +/-   ##
=======================================
  Coverage   62.39%   62.39%           
=======================================
  Files         181      181           
  Lines        6646     6646           
  Branches        6        6           
=======================================
  Hits         4147     4147           
  Misses       2496     2496           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf16f1...009d56f. Read the comment docs.

thymikee
thymikee reviewed May 17, 2017
View reviewed changes
docs/en/GettingStarted.md Outdated

```
npm install --save-dev jest
yarn add --dev jest
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling that inexperienced users may try to do both, as the commands are in the same block. How about:

Install Jest using npm:

npm install --save-dev jest

or yarn:

yarn add --dev jest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@cpojer cpojer merged commit ce6123f into jestjs:master May 17, 2017
@Haroenv Haroenv deleted the patch-2 branch May 17, 2017 07:59
@renovate-bot renovate-bot mentioned this pull request May 17, 2017
Merged
@renovate-bot renovate-bot mentioned this pull request May 17, 2017
Merged
orta pushed a commit to orta/jest that referenced this pull request Jul 7, 2017
@Haroenv @orta
docs(gettingStarted): add Yarn install (jestjs#3588)
821f35c 
* docs(gettingStarted): add Yarn install

cc @cpojer

* Update GettingStarted.md
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@Haroenv @cpojer
docs(gettingStarted): add Yarn install (jestjs#3588)
922a134 
* docs(gettingStarted): add Yarn install

cc @cpojer

* Update GettingStarted.md
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
CLA Signed ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Haroenv @codecov-io @thymikee @cpojer @facebook-github-bot