Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--projects should filter by directory #5199

Closed
ericclemmons opened this issue Dec 30, 2017 · 5 comments · Fixed by #5412
Closed

--projects should filter by directory #5199

ericclemmons opened this issue Dec 30, 2017 · 5 comments · Fixed by #5412
Labels
🐛 Bug good first issue

Comments

@ericclemmons
Copy link
Contributor

Do you want to request a feature or report a bug?

Bug.

What is the current behavior?

Jest incorrectly processes files instead of only the folders within them.

$ jest --projects packages/*
/Users/eric/Projects/my/project/packages/README.md:1
(function (exports, require, module, __filename, __dirname) { # My Project
                                                              ^

SyntaxError: Invalid or unexpected token

What is the expected behavior?

Filter by .isDirectory().

Please provide your exact Jest configuration and mention your Jest, node,
yarn/npm version and operating system.

jest@22.0.4
yarn@1.3.2
node@8.9.1
@ndelangen
Copy link
Contributor

Would I be correct in implementing this filtering here:
https://github.com/facebook/jest/blob/a43977281802b192b6cdb57a1dc806bdf42169d1/packages/jest-cli/src/cli/index.js#L253

@SimenB
Copy link
Member

SimenB commented Jan 11, 2018

@ndelangen yeah

@SimenB
Copy link
Member

SimenB commented Jan 11, 2018

I'm not sure it's correct though, you should be able to pass a config file directly

ericclemmons added a commit to ericclemmons/jest that referenced this issue Jan 28, 2018
@ericclemmons
Add reference to jestjs#5199 in CHANGELOG.md
868419e
@ericclemmons ericclemmons mentioned this issue Jan 28, 2018
Merged
@ericclemmons
Copy link
Contributor Author

See #5412.

cpojer pushed a commit that referenced this issue Feb 1, 2018
@ericclemmons @cpojer
Filter non-JS files from require when using glob with --projects (#…
dea270b 
…5412)

* Add test for workspaces with a README.md in the root

* Filter projects to directories & require-able files only

This ensures `packages/*` catches folders & not README.md

* Add reference to #5199 in CHANGELOG.md

* Remove custom testDir
jessecarfb pushed a commit to jessecarfb/jest that referenced this issue Feb 2, 2018
@ericclemmons @jessecarfb
Filter non-JS files from require when using glob with --projects (j…
1f51035 
…estjs#5412)

* Add test for workspaces with a README.md in the root

* Filter projects to directories & require-able files only

This ensures `packages/*` catches folders & not README.md

* Add reference to jestjs#5199 in CHANGELOG.md

* Remove custom testDir
@renovate renovate bot mentioned this issue Feb 14, 2018
Open
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐛 Bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filter non-JS files from require when using glob with --projects ericclemmons/jest
4 participants
@ericclemmons @SimenB @ndelangen @thymikee