Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-cli): fix typo in options when spawning coverage workers #5374

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

dlmr
Copy link
Contributor

@dlmr dlmr commented Jan 23, 2018

Summary
Fixes a typo in the options when spawning coverage workers. This change does not change the behaviour of the code as there is a fallback in jest-worker that resolves to the same method. https://github.com/facebook/jest/blob/master/packages/jest-worker/src/index.js#L95

Test plan
Matches the expected option in jest-worker.

@codecov-io
Copy link

Codecov Report

Merging #5374 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5374   +/-   ##
=======================================
  Coverage   61.33%   61.33%           
=======================================
  Files         205      205           
  Lines        6924     6924           
  Branches        3        4    +1     
=======================================
  Hits         4247     4247           
  Misses       2676     2676           
  Partials        1        1
Impacted Files Coverage Δ
...ckages/jest-cli/src/reporters/coverage_reporter.js 66.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec36ae...b912884. Read the comment docs.

@cpojer cpojer merged commit be66ccc into jestjs:master Jan 23, 2018
@dlmr dlmr changed the title fix(jest-cli): fix typo in options when spawning workers fix(jest-cli): fix typo in options when spawning coverage workers Jan 23, 2018
@cpojer
Copy link
Member

cpojer commented Jan 23, 2018

We should probably add a test for this. Do you mind sending a follow-up PR for that?

@dlmr dlmr deleted the patch-1 branch January 23, 2018 17:58
@dlmr
Copy link
Contributor Author

dlmr commented Jan 23, 2018

I can take a look at it, but no promises. 🙂

Is my assumption correct that this should be verified by Flow? Verifying that the options we pass in match FarmOptions which I assume we will need to hoist into the general types folder?

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants