Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace make-dir with fs.mkdir #10136

Merged
merged 4 commits into from
Jun 23, 2020
Merged

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Jun 6, 2020

Summary

Builtin fs.mkdir supports recursive option since node v10.

See here https://nodejs.org/docs/latest-v10.x/api/fs.html#fs_fs_mkdirsync_path_option

@@ -5,12 +5,12 @@
* LICENSE file in the root directory of this source tree.
*/

import makeDir = require('make-dir');
import * as fs from 'graceful-fs';
import type {Config} from '@jest/types';

export default function createDirectory(path: Config.Path): void {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably remove this helper at some point

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB changed the title chore: replace make-dir with fs.mkdir chore: replace make-dir with fs.mkdir Jun 23, 2020
@SimenB SimenB merged commit 17c3f14 into jestjs:master Jun 23, 2020
sauravhiremath pushed a commit to MLH-Fellowship/jest that referenced this pull request Jul 20, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants