chore(jest-resolve): improve types #10239
Conversation
| @@ -31,11 +31,11 @@ export default class ModuleNotFoundError extends Error { | |||
|
|
|||
| let message = this._originalMessage; | |||
|
|
|||
| if (this?.requireStack?.length && this!.requireStack!.length > 1) { | |||
| if (this.requireStack?.length && this.requireStack.length > 1) { | |||
There was a problem hiding this comment.
| if (this.requireStack?.length && this.requireStack.length > 1) { | |
| if (this.requireStack?.length > 1) { |
?
There was a problem hiding this comment.
> requires both sides to be a number, so you can't do undefined > 1 in TS - I thought about merging these but decided against it as I think the alternatives don't really add much while not being as clean, i.e (this.requireStack?.length ?? 0) > 1
| @@ -21,11 +21,19 @@ type ResolverOptions = { | |||
| rootDir?: Config.Path; | |||
| }; | |||
|
|
|||
| declare global { | |||
| namespace NodeJS { | ||
| export interface Process { | ||
| // "private" api | ||
| binding(type: string): {}; |
There was a problem hiding this comment.
won't this pollute the global definition of all consumers as well? I'm down with adding pnp as optional, but this one is purposefully not added to global types by DT and is highly discouraged to use by Node itself
There was a problem hiding this comment.
Yeah I realised this after I pushed. I'll restore the declare and just add & process.
There was a problem hiding this comment.
fwiw this should be "fine" as it only takes effect when this file is imported, which none of the d.tss do since it's not a public function, but I'll change it for peace of mind all the same.
|
Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Improves the types of
jest-resolvemainly for #10177, and also cleaning up a few little nits around the place, including a nice little find inModuleNotFoundError.Test plan
Run the tests and see if anything breaks 🚂