Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(leak-detector): wait more ticks for GC to run #10366

Merged
merged 3 commits into from
Aug 5, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Aug 5, 2020

Summary

See nodejs/node#34636

Test plan

Green CI

setImmediate(() => resolve(this._isReferenceBeingHeld)),
);
// wait some ticks to allow GC to run properly, see https://github.com/nodejs/node/issues/34636#issuecomment-669366235
for (let i = 0; i < 10; i++) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

measured, it takes about 0.3ms on my machine when running this module's unit tests

@SimenB SimenB merged commit f077751 into jestjs:master Aug 5, 2020
@SimenB SimenB deleted the leak-detector-node-14 branch August 5, 2020 19:29
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants