fix: add missing module.path field to modules
#10615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Oct 10, 2020
| @@ -83,8 +83,7 @@ const defaultTransformOptions: InternalModuleOptions = { | |||
| supportsStaticESM: false, | |||
| }; | |||
|
|
|||
| type InitialModule = Partial<Module> & | |||
There was a problem hiding this comment.
The Partial made this missing not be a type error
SimenB
commented
Oct 10, 2020
| @@ -83,8 +83,7 @@ const defaultTransformOptions: InternalModuleOptions = { | |||
| supportsStaticESM: false, | |||
| }; | |||
|
|
|||
| type InitialModule = Partial<Module> & | |||
| Pick<Module, 'children' | 'exports' | 'filename' | 'id' | 'loaded'>; | |||
| type InitialModule = Omit<Module, 'require' | 'parent' | 'paths'>; | |||
There was a problem hiding this comment.
might consider doing new Module and inspect what's on it to see what fields we should include, but meh
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://nodejs.org/docs/latest/api/modules.html#modules_module_path
Test plan
Unit test updated