Support index in it.each with template strings #10763
Conversation
|
Hi @k-yle! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Seems useful to me, thanks! Could you also update the changelog?
@mattphillips thoughts?
|
@SimenB I've updated the changelog. |
|
All passed now 🙂 macOS is unfortunately a bit flaky |
|
This looks good, let's go for it! We're currently migrating to Docusaurus 2, so holding off on landing any PRs with docs changes as porting them are painful. But will get back to it once we're ready to 🙂 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
#6414 added support for indexes in jest-each using the table syntax, but not the tagged-template string version.
This PR allows
$#to be used as the index/row number. I chose$#to match the$variablesyntax already in use with tagged-template literals. Note that this is different to%#in the table syntax.Test plan
The updated unit tests for template.test.ts are passing.