Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test location for test.each on windows #10871

Merged
merged 3 commits into from
Nov 26, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Nov 26, 2020

Summary

Unblocks #10686.

Test plan

I've tested on Windows via Virtualbox. I've also added a CI build that runs the test on all 3 OSes using node LTS

@@ -18,7 +19,7 @@ import {ROOT_DESCRIBE_BLOCK_NAME, getState} from './state';

const stackUtils = new StackUtils({cwd: 'A path that does not exist'});

const jestEachBuildDir = path.dirname(require.resolve('jest-each'));
const jestEachBuildDir = slash(path.dirname(require.resolve('jest-each')));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the bugfix

@SimenB SimenB changed the title fix: fix location for test.each on windows fix: test location for test.each on windows Nov 26, 2020
@SimenB SimenB merged commit e442dec into jestjs:master Nov 26, 2020
@SimenB SimenB deleted the widnows-circus-test-location branch November 26, 2020 15:58
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants