Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vendor node crawler from sane #10919

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Dec 5, 2020

Summary

See #10048 for motivation - tl;dr sane is unmaintained, so we should migrate away from it.

Test plan

The watcher seems to work fine locally (macOS). Should be tested more extensively, tho. Advantage here over #10048 is that it's only the node watcher that changes. Disadvantage is that we vendor all the parts of sane we use...

@@ -23,6 +23,7 @@ module.exports = {
modulePathIgnorePatterns: [
'examples/.*',
'packages/.*/build',
'packages/.*/tsconfig.*',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed while debugging watch events

@SimenB SimenB force-pushed the remove-sane branch 3 times, most recently from 76faf90 to d4f488c Compare December 5, 2020 13:33
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants