Make testFailureExitCode compatible with bail option #10958
Merged
+31
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,7 @@ const HG = 'hg --config ui.username=jest_test'; | |||
|
|
|||
| const gitVersionSupportsInitialBranch = (() => { | |||
| const {stdout} = run(`${GIT} --version`); | |||
| const gitVersion = stdout.split(' ').slice(-1)[0]; | |||
| const gitVersion = stdout; | |||
There was a problem hiding this comment.
This was necessary fix since on my machine, it gives git version 2.24.3 (Apple Git-128)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Calling jest with option "testFailureExitCode" works as expected. However, when combined with option "bail" it always fails with exit code "1" instead of the exit code provided with "testFailureExitCode".
Test plan
There's a test case in this PR that demonstrates the issue.