Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(TestingAsyncCode.md): add note about not mixing done w/promises #11077

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Feb 11, 2021

Summary

I was confused by the docs when to use done() in my tests. I thought it might be nice to mention this in the docs - don't mix done() with Promises.

See comment: coder/code-server#2648 (comment)

Test plan

N/A (docs only)

@jsjoeio jsjoeio marked this pull request as ready for review February 11, 2021 18:32
@codecov-io
Copy link

Codecov Report

Merging #11077 (e7e396f) into master (42f78d4) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11077      +/-   ##
==========================================
- Coverage   64.22%   64.20%   -0.02%     
==========================================
  Files         305      305              
  Lines       13265    13265              
  Branches     3238     3238              
==========================================
- Hits         8519     8517       -2     
- Misses       4054     4055       +1     
- Partials      692      693       +1     
Impacted Files Coverage Δ
packages/expect/src/utils.ts 94.83% <0.00%> (-1.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f78d4...e7e396f. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could you update the versioned docs as well?

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful, thanks!

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Feb 15, 2022

@SimenB should be good now!

@SimenB SimenB merged commit e233b91 into jestjs:main Feb 15, 2022
@jsjoeio jsjoeio deleted the patch-1 branch February 15, 2022 23:56
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants