-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(TestingAsyncCode.md): add note about not mixing done w/promises #11077
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11077 +/- ##
==========================================
- Coverage 64.22% 64.20% -0.02%
==========================================
Files 305 305
Lines 13265 13265
Branches 3238 3238
==========================================
- Hits 8519 8517 -2
- Misses 4054 4055 +1
- Partials 692 693 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! could you update the versioned docs as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonderful, thanks!
@SimenB should be good now! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
I was confused by the docs when to use
done()
in my tests. I thought it might be nice to mention this in the docs - don't mixdone()
with Promises.See comment: coder/code-server#2648 (comment)
Test plan
N/A (docs only)