-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove support for runScript
#11155
Conversation
@@ -142,6 +142,13 @@ async function runTestInternal( | |||
docblockPragmas, | |||
testPath: path, | |||
}); | |||
|
|||
if (typeof environment.getVmContext !== 'function') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we warn if runScript
is present? Might make it harder for a single test env to support multiple versions of Jest, bt also less confusing than "why isn't my code running"
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #11155 +/- ##
==========================================
+ Coverage 64.19% 64.21% +0.02%
==========================================
Files 307 307
Lines 13372 13369 -3
Branches 3260 3258 -2
==========================================
+ Hits 8584 8585 +1
+ Misses 4083 4081 -2
+ Partials 705 703 -2
Continue to review full report at Codecov.
|
Will merge after we land the website update |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
It cannot be used for ESM anyways, so let's clean up our code a bit
Test plan
Green CI