Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: jest --watch fails with ambiguous argument #11160

Merged
merged 1 commit into from
Mar 7, 2021
Merged

fix: jest --watch fails with ambiguous argument #11160

merged 1 commit into from
Mar 7, 2021

Conversation

yokomotod
Copy link
Contributor

@yokomotod yokomotod commented Mar 6, 2021 •
edited
Loading

Summary

Hi. This PR fixes #10149.

Now jest --watch, jest --lastCommit, --changedSince work fine even if there are same name revision and filename.

Test plan

e2e test modified

@facebook-github-bot
Copy link
Contributor

Hi @yokomotod!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

yokomotod
yokomotod commented Mar 6, 2021
View reviewed changes
packages/jest-changed-files/src/git.ts
'--other',
'--modified',
'--exclude-standard',
'--',
Copy link
Contributor Author

@yokomotod yokomotod Mar 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: git ls-files won't fail so not require --, just unifying same style with git diff

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@yokomotod
Copy link
Contributor Author

e2e/__tests__/jestChangedFiles.test.ts: handles a bad revision for "changedSince", for hg failed on MacOS...

but it's not about git but hg, and seems master CI failed as well 🤔

SimenB
SimenB approved these changes Mar 7, 2021
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yokomotod!

@SimenB SimenB merged commit 46debe9 into jestjs:master Mar 7, 2021
@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oudomskn oudomskn oudomskn approved these changes

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jest --watch fails with ambiguous argument
4 participants
@yokomotod @facebook-github-bot @SimenB @oudomskn