Allow projects in TypeScript Config to be an array of ProjectConfig #11285
Conversation
|
Hi @TranquilMarmot! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
thanks for the PR! As mentioned inline, you've modified the types after normalization, which is incorrect. You wanna modify this one (InitialOptions): https://github.com/facebook/jest/blob/d1ad64c0b5cdf68a73e11a12d7770be7d1381584/packages/jest-types/src/Config.ts#L187
You can add a type test here: https://github.com/facebook/jest/blob/master/test-types/top-level-config.test.ts
packages/jest-types/src/Config.ts
Outdated
| @@ -184,7 +184,7 @@ export type InitialOptions = Partial<{ | |||
| preprocessorIgnorePatterns: Array<Glob>; | |||
| preset: string | null | undefined; | |||
| prettierPath: string | null | undefined; | |||
| projects: Array<Glob>; | |||
| projects: Array<Glob> | Array<Omit<InitialOptions, keyof GlobalConfig>>; | |||
There was a problem hiding this comment.
self reference works? if not we can have one type without projects, and then one that extends it
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #11284
It was noticed when trying to write a
jest.config.tsfile that theprojectskey only allowsArray<Glob>This is at odds with the docs: https://jestjs.io/docs/configuration#projects-arraystring--projectconfig
Test plan
This was tested locally by changing
node_modules/@jest/types/build/Config.d.ts