-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(read-config): allow multiple projects with programmatic usage #11307
Conversation
Please let me know if you want me to add an integration test for this. |
Codecov Report
@@ Coverage Diff @@
## master #11307 +/- ##
==========================================
- Coverage 64.19% 64.18% -0.02%
==========================================
Files 308 308
Lines 13528 13529 +1
Branches 3297 3298 +1
==========================================
- Hits 8684 8683 -1
Misses 4131 4131
- Partials 713 715 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh, nice! An e2e test for this would be great, yeah 🙂 Along with a changelog entry
Thanks for the review @SimenB. I've added an e2e test, as well as the changelog entry. 👷♂️✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! Just test nitpicks 🙂
test('run programmatically with multiple projects', () => { | ||
const {stdout, exitCode} = run(`node run-jest.js `, dir); | ||
expect(exitCode).toEqual(0); | ||
expect(stdout).toMatch(/Done/); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you pass stdout
through extractSummaries
or something like that and snapshot it to ensure both tests show up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A great addition, will do that and use snapshotting 👍
Also, CI complains about missing copyright headers 🙂 |
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Great feedback 👍 I've implemented all of it and added the copyright header (what a waste of disk space to have that in each file, but what can you do I guess 🤷♂️) |
I tweaked the test, btw. But it seems GH Actions does not like it. Maybe we need to pass the output through |
Ah, flake in addition. We don't really care about |
Ah yes, I see what you mean. I've removed |
I think we still need to pass through |
Ok, I think this should be it then 🍏🟢 |
Thanks! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Allow for
runCli
with multipleprojects
.Fixes #11213
Fixes #7415
Test plan
I've tested this change in the reproduction zip of #11213. Output was: