Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update timers config description #11376

Merged
merged 5 commits into from
May 6, 2021

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented May 5, 2021

Summary

This PR clarifies the timers configuration property based on the conversation in #11370.

Fixes #11370

Test plan

Documentation change only.

@facebook-github-bot
Copy link
Contributor

Hi @blimmer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #11376 (91e5191) into master (ba84480) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11376   +/-   ##
=======================================
  Coverage   64.19%   64.19%           
=======================================
  Files         308      308           
  Lines       13519    13519           
  Branches     3293     3293           
=======================================
  Hits         8678     8678           
  Misses       4126     4126           
  Partials      715      715           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba84480...91e5191. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! just a couple of nits for the links 🙂

docs/Configuration.md Outdated Show resolved Hide resolved
website/versioned_docs/version-25.x/Configuration.md Outdated Show resolved Hide resolved
website/versioned_docs/version-26.x/Configuration.md Outdated Show resolved Hide resolved
website/versioned_docs/version-26.x/Configuration.md Outdated Show resolved Hide resolved
blimmer and others added 4 commits May 6, 2021 08:35
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
@blimmer
Copy link
Contributor Author

blimmer commented May 6, 2021

Updated!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! from deploy preview the links work 🙂

@SimenB SimenB merged commit 3028bb1 into jestjs:master May 6, 2021
mprinc pushed a commit to mprinc/jest that referenced this pull request May 9, 2021
@github-actions
Copy link

github-actions bot commented Jun 6, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting timers config property to modern does not use modern mode by default in test files
4 participants