Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jest-mock fn and spyOn. #11480

Merged
merged 1 commit into from
May 29, 2021
Merged

Fix jest-mock fn and spyOn. #11480

merged 1 commit into from
May 29, 2021

Conversation

cpojer
Copy link
Member

@cpojer cpojer commented May 29, 2021

Summary

The fn and spyOn exports for jest-mock are broken in Jest 27, see:

Screen Shot 2021-05-29 at 21 34 49

This PR fixes it.

Test plan

Added a new test.

@codecov-commenter
Copy link

Codecov Report

Merging #11480 (d9fb9ac) into master (e9802d3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11480   +/-   ##
=======================================
  Coverage   68.94%   68.94%           
=======================================
  Files         312      312           
  Lines       16309    16309           
  Branches     4721     4721           
=======================================
  Hits        11245    11245           
  Misses       5036     5036           
  Partials       28       28           
Impacted Files Coverage Δ
packages/jest-mock/src/index.ts 84.98% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9802d3...d9fb9ac. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants