-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expect): Add equality support for Array Buffers to ToStrictEqual method #11805
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11805 +/- ##
==========================================
+ Coverage 69.04% 69.06% +0.02%
==========================================
Files 312 312
Lines 16366 16377 +11
Branches 4746 4749 +3
==========================================
+ Hits 11300 11311 +11
Misses 5039 5039
Partials 27 27
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Implementation looks good, just some formatting and type suggestions 🙂
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Can you fix the eslint errors? |
Done. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Adds equality checks for Array Buffers in
ToStrictEqual
method, Fixes #11770.Test plan
The changes add a new entry to the array
toStrictEqualTesters
in expect package'smatchers.ts
and a new util functionarrayBufferEquality
. I've added tests inmatchers.test.js
to test the actual method and tests inutils.test.ts
to test the util function.