-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename config option name to id #11981
Conversation
@jeysal i am getting import/order error when running yarn test. But It is already in correct order and after saving that file it moves to it's correct position but still showing error in terminal when i used yarn test |
7805e40
to
cc3c296
Compare
1fffca6
to
dc19f4d
Compare
@Udit-takkar lint seems to pass on CI - but there are quite a few tests failing, see CI check results for those. Many of them look very easy to fix, once you've got most of them green let me know and any tests that you're not sure how to fix we can look at together |
@jeysal What is the command to test these check like running all tests for
Also I am busy with some hackathon till 27th. Will try resolving after that. Don't mark this one as stale. |
Looks like an Apple M1 problem (no MongoDB binary available for macos with arm64 architecture). Found this to resolve typegoose/mongodb-memory-server#505 |
dc19f4d
to
a38bf11
Compare
317928d
to
5931406
Compare
@jeysal just couple of test are failing now. can you help? |
Hi - I think that was just a matter of a |
Ok |
@Udit-takkar could you please make it a draft as it is a breaking change, this would make the PR page a little bit easy to move around |
@Biki-das anything else? |
Nope😃, thanks! |
@SimenB Just to draw your attention, it seems like this PR is ready to land. Marked as a draft, but looking at the conversation becomes clear that the job was finished and it can be merged. If CI is still passing, of course. Here are few duplicates to be closed after merging: #10051, #10592, #11089, #12235 |
Thanks @mrazauskas! I'll update it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #10013
Closes #10051
Closes #10592
Closes #11089
Closes #12235
I have renamed name to id in all the relevant files including tests.
Need help on one test case that is failing in jest/e2e/native-esm/tests/native-esm.test.js
15:1 error
node:dnsimport should occur before import of
pathimport/order
Test plan