-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to JSDOM 19 #12290
feat: upgrade to JSDOM 19 #12290
Conversation
Hi @marcelltoth! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Node 10 failures are expected as JSDOM dropped support for it (and 15) because they are EOL. Won't be a factor as Jest 28 will also drop Node 10/15 support anyway, see #12220 |
Hey @marcelltoth, and thanks for the PR! Could you resolve the conflicts? 🙂 |
fbe1922
to
3c3e216
Compare
Hi @SimenB no problem! I rebased it and resolved all conflicts, should pass now. |
Codecov Report
@@ Coverage Diff @@
## main #12290 +/- ##
=======================================
Coverage 66.94% 66.94%
=======================================
Files 329 329
Lines 17345 17345
Branches 5059 5059
=======================================
Hits 11612 11612
Misses 5701 5701
Partials 32 32 Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Resolves #12023
Summary
Bumps JSDOM to 19. See #12023 for details.
As this is a breaking change this should go into Jest 28, not before.
Test plan
Green CI?