Add `--ignoreProjects` CLI argument to ignore test suites by project name #12620

F3n67u · 2022-03-31T14:36:07Z

Summary

Add --ignoreProjects CLI argument to ignore test suites by project name

close #12618

Test plan

…name

docs/CLI.md

Co-authored-by: Paavo Bennett <paavobennettis+github@gmail.com>

…ojects

mrazauskas · 2022-04-01T05:18:13Z

Just thinking out loud. I am fine with the implementation, only not so sure if word ignore is describing the option well?

What about --omitProjects? Or perhaps --skipProjects? (A pair of --onlyProjects and --skipProjects might be a good choice, but perhaps that is unnecessary change.)

F3n67u · 2022-04-01T10:08:18Z

Just thinking out loud. I am fine with the implementation, only not so sure if word ignore is describing the option well?

What about --omitProjects? Or perhaps --skipProjects? (A pair of --onlyProjects and --skipProjects might be a good choice, but perhaps that is unnecessary change.)

@mrazauskas I will vote for --ignoreProjects. jest already has an --testPathIgnorePatterns cli option. ignoreProjects will make cli option more consistent.

and ignore is used a lot more than the skip word in the javascript community. for example:

SimenB

thanks, I like it! can you add a changelog entry as well?

SimenB · 2022-04-01T10:22:44Z

docs/CLI.md

@@ -224,6 +224,10 @@ This feature is an escape-hatch. If Jest doesn't exit at the end of a test run,

 Show the help information, similar to this page.

+### `--ignoreProjects <project1> ... <projectN>`


what happens if both this and selectProjects is used? Ideally it should be a configuration error. (and be mentioned in the docs)

selectProjects and ignoreProjects could be used together. now it seems no need to do it because we don't support glob pattern, but I think to allow them to be used together will be better (not include a breaking change) because we maybe support glob in both selectProjects and ignoreProjects. just as Typescript allows you to use include and exclude together.

and I don't think there is any reason to restrict our user to use them together, If they like to, we will allow them to use.

see how our user's opinion here: #12618 (comment)

@F3n67u Glob support for both would be awesome as well, especially if you're using https://github.com/jest-community/jest-runner-eslint so you could do ignore *-test when running tests and ignore *-lint when running lint.

Mind opening up a separate feature request?

F3n67u · 2022-04-01T10:35:10Z

e2e/__tests__/selectProjects.test.ts

+    });
+  });
+
+  describe('when Jest is started with `--selectProjects first-project second-project --ignoreProjects first-project` ', () => {


@SimenB here is the test for using --selectProjects and --ignoreProjects together.

packages/jest-types/src/Config.ts

F3n67u · 2022-04-01T11:19:47Z

thanks, I like it! can you add a changelog entry as well?

done.

SimenB

thanks!

SimenB · 2022-04-05T15:13:57Z

https://github.com/facebook/jest/releases/tag/v28.0.0-alpha.8

github-actions · 2022-05-08T00:08:56Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

Add --ignoreProjects CLI argument to ignore test suites by project …

287aad4

…name

facebook-github-bot added the cla signed label Mar 31, 2022

F3n67u changed the title ~~Add --ignoreProjects CLI argument to ignore test suites by project …~~ Add --ignoreProjects CLI argument to ignore test suites by project name Mar 31, 2022

F3n67u added 5 commits March 31, 2022 22:55

add test

9d2e091

args check

7f9090f

fix type

6f7f542

add more test

185b732

adjust warning

6942a8e

eliw00d reviewed Mar 31, 2022

View reviewed changes

docs/CLI.md Outdated Show resolved Hide resolved

F3n67u and others added 4 commits April 1, 2022 08:24

Update docs/CLI.md

a38ddd4

Co-authored-by: Paavo Bennett <paavobennettis+github@gmail.com>

refactor notIgnore

bc92ed9

Merge branch 'ignoreProjects' of github.com:F3n67u/jest into ignorePr…

29abd26

…ojects

unnamed project

4871daa

F3n67u marked this pull request as ready for review April 1, 2022 05:04

optimize message

43e0fa8

F3n67u force-pushed the ignoreProjects branch from 6820abb to 43e0fa8 Compare April 1, 2022 05:08

SimenB approved these changes Apr 1, 2022

View reviewed changes

add changelog

01315cb

F3n67u commented Apr 1, 2022

View reviewed changes

mrazauskas reviewed Apr 1, 2022

View reviewed changes

packages/jest-types/src/Config.ts Outdated Show resolved Hide resolved

type sort-keys

f71c418

SimenB approved these changes Apr 4, 2022

View reviewed changes

SimenB merged commit eb2146f into jestjs:main Apr 4, 2022

F3n67u deleted the ignoreProjects branch April 5, 2022 01:43

github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `--ignoreProjects` CLI argument to ignore test suites by project name #12620

Add `--ignoreProjects` CLI argument to ignore test suites by project name #12620

F3n67u commented Mar 31, 2022 •

edited

Loading

mrazauskas commented Apr 1, 2022

F3n67u commented Apr 1, 2022 •

edited

Loading

SimenB left a comment

SimenB Apr 1, 2022

F3n67u Apr 1, 2022 •

edited

Loading

F3n67u Apr 1, 2022

eliw00d Apr 7, 2022

SimenB Apr 7, 2022

eliw00d Apr 7, 2022

F3n67u Apr 1, 2022

F3n67u commented Apr 1, 2022

SimenB left a comment

SimenB commented Apr 5, 2022

github-actions bot commented May 8, 2022

		@@ -224,6 +224,10 @@ This feature is an escape-hatch. If Jest doesn't exit at the end of a test run,

		Show the help information, similar to this page.

		### `--ignoreProjects <project1> ... <projectN>`

Add --ignoreProjects CLI argument to ignore test suites by project name #12620

Add --ignoreProjects CLI argument to ignore test suites by project name #12620

Conversation

F3n67u commented Mar 31, 2022 • edited Loading

Summary

Test plan

mrazauskas commented Apr 1, 2022

F3n67u commented Apr 1, 2022 • edited Loading

SimenB left a comment

Choose a reason for hiding this comment

SimenB Apr 1, 2022

Choose a reason for hiding this comment

F3n67u Apr 1, 2022 • edited Loading

Choose a reason for hiding this comment

F3n67u Apr 1, 2022

Choose a reason for hiding this comment

eliw00d Apr 7, 2022

Choose a reason for hiding this comment

SimenB Apr 7, 2022

Choose a reason for hiding this comment

eliw00d Apr 7, 2022

Choose a reason for hiding this comment

F3n67u Apr 1, 2022

Choose a reason for hiding this comment

F3n67u commented Apr 1, 2022

SimenB left a comment

Choose a reason for hiding this comment

SimenB commented Apr 5, 2022

github-actions bot commented May 8, 2022

Add `--ignoreProjects` CLI argument to ignore test suites by project name #12620

Add `--ignoreProjects` CLI argument to ignore test suites by project name #12620

F3n67u commented Mar 31, 2022 •

edited

Loading

F3n67u commented Apr 1, 2022 •

edited

Loading

F3n67u Apr 1, 2022 •

edited

Loading