Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated call to __proto__ with Object.setPrototypeOf #13256

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Replace deprecated call to __proto__ with Object.setPrototypeOf #13256

merged 3 commits into from
Sep 13, 2022

Conversation

guimard
Copy link
Contributor

@guimard guimard commented Sep 13, 2022

Summary

The use of proto is deprecated (see #13255). Note that it is not enough to launch jest with node --disable-proto=throw, at least @sinonjs/commons has to be patched (see Debian patch)

@facebook-github-bot
Copy link
Contributor

Hi @guimard!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@guimard guimard mentioned this pull request Sep 13, 2022
Closed
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

SimenB
SimenB approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB linked an issue Sep 13, 2022 that may be closed by this pull request
[Bug]: please drop deprecated __proto__ use #13255
Closed
@SimenB SimenB changed the title Replace deprecated call to __proto__ by Object.setPrototypeOf Replace deprecated call to __proto__ with Object.setPrototypeOf Sep 13, 2022
@SimenB SimenB merged commit aa9dca4 into jestjs:main Sep 13, 2022
@guimard guimard mentioned this pull request Sep 14, 2022
Closed
@guimard guimard deleted the replace-deprecated-proto-use branch September 14, 2022 09:01
@SimenB
Copy link
Member

SimenB commented Sep 28, 2022

https://github.com/facebook/jest/releases/tag/v29.1.0

@matejcik matejcik mentioned this pull request Oct 6, 2022
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Smrtnyk Smrtnyk Smrtnyk left review comments

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: please drop deprecated __proto__ use
4 participants
@guimard @facebook-github-bot @SimenB @Smrtnyk