-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Cleanup incorrect links in CHANGELOG.md #13857
Conversation
Ah nice, thanks @SuperSodaSea!
Can you add that script to the repo? We can run it as part of some CI run to verify links are correct |
@SimenB I added
It can be run via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
I happened to find some of the PRs' links in CHANGELOG.md are incorrect (different IDs in text and URLs), due to mistake when copying and pasting them:
https://github.com/facebook/jest/blob/48ddbf49535290aa9cd0e990f44d583c1baab96e/CHANGELOG.md?plain=1#L862
So I wrote a small script like this to find all of them (hopefully):
And it outputs:
I manually checked them one by one and fixed them in this PR.
Test plan
(Maybe we can add a step somewhere in the CI to detect such error.)A CI step is added to check this, see discussion below.