Support custom platforms on jest-haste-map #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I sought to maintain all pre-existing behaviors with this change. Calling it with an arbitrary platforms array or no array at all should still return the same result for previously-supported platforms. |
|
Thanks @andrewimm. As a follow-up, I feel like it may make sense to turn the platforms object into a Set in the constructor so that lookups will be faster. Would you be interested in sending a PR for this? |
|
Sure, happy to follow up with a move to |
cpojer
pushed a commit
that referenced
this pull request
Mar 17, 2017
* [jest-jasmine2] Split `jasmine-light` over multiple files. * Don't wrap things that don't need to be wrapped. * Don't wrap things that don't need to be wrapped (again). * Lint. * [jest-jasmine2] Trim `jasmine` singleton. * Adding NHL to companies that use Jest (#3163) * Support custom platforms on jest-haste-map (#3162) * Support custom platforms on jest-haste-map * Run prettier * Rebase.
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
* Support custom platforms on jest-haste-map * Run prettier
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
* [jest-jasmine2] Split `jasmine-light` over multiple files. * Don't wrap things that don't need to be wrapped. * Don't wrap things that don't need to be wrapped (again). * Lint. * [jest-jasmine2] Trim `jasmine` singleton. * Adding NHL to companies that use Jest (jestjs#3163) * Support custom platforms on jest-haste-map (jestjs#3162) * Support custom platforms on jest-haste-map * Run prettier * Rebase.
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Support custom platforms on jest-haste-map * Run prettier
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* [jest-jasmine2] Split `jasmine-light` over multiple files. * Don't wrap things that don't need to be wrapped. * Don't wrap things that don't need to be wrapped (again). * Lint. * [jest-jasmine2] Trim `jasmine` singleton. * Adding NHL to companies that use Jest (jestjs#3163) * Support custom platforms on jest-haste-map (jestjs#3162) * Support custom platforms on jest-haste-map * Run prettier * Rebase.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The options object allows specification of custom platforms, but jest-haste-map doesn't use this when checking for duplicates, which leads to a lot of unnecessary warning messages on custom platforms.
Test plan
Ran these changes on a project with the following package.json configuration:
And two files:
MyModule.jsandMyModule.vr.js, both of which contain@providesModule MyModuleWithout these changes, jest-haste-map produces a warning. With these changes, no warnings occur.