Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defensively code BabylonParser object accessors #3259

Merged
merged 2 commits into from
Apr 11, 2017
Merged

Defensively code BabylonParser object accessors #3259

merged 2 commits into from
Apr 11, 2017

Conversation

ripixel
Copy link

@ripixel ripixel commented Apr 5, 2017

Summary

Object properties are accessed before the object can be said to exist in a few cases in the BabylonParser, causing fatal JS errors in applications that suffer these bugs. Defensively coding this parser to check for existence before attempting to access properties ensures no JS fatal errors.

Test plan

BabylonParser tests still green post-changes; however, fixes my specific issues while using jest-community/vscode-jest#92 which uses jest-editor-support.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

codecov-io commented Apr 5, 2017

Codecov Report

Merging #3259 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3259   +/-   ##
=======================================
  Coverage   64.24%   64.24%           
=======================================
  Files         175      175           
  Lines        6436     6436           
  Branches        4        4           
=======================================
  Hits         4135     4135           
  Misses       2300     2300           
  Partials        1        1
Impacted Files Coverage Δ
...s/jest-editor-support/src/parsers/BabylonParser.js 98.94% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 706ce99...50fd1e6. Read the comment docs.

@aaronabramov
Copy link
Contributor

@orta do you mind looking at this?

@orta
Copy link
Member

orta commented Apr 7, 2017

Yep this looks great 👍

@aaronabramov
Copy link
Contributor

thank you!
@anarresk can you resolve conflicts? :)

@cpojer cpojer merged commit a1603db into jestjs:master Apr 11, 2017
skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@ripixel ripixel deleted the defensively-code-babylon-parser branch October 24, 2017 10:46
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants