-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defensively code BabylonParser object accessors #3259
Defensively code BabylonParser object accessors #3259
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #3259 +/- ##
=======================================
Coverage 64.24% 64.24%
=======================================
Files 175 175
Lines 6436 6436
Branches 4 4
=======================================
Hits 4135 4135
Misses 2300 2300
Partials 1 1
Continue to review full report at Codecov.
|
@orta do you mind looking at this? |
Yep this looks great 👍 |
thank you! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Object properties are accessed before the object can be said to exist in a few cases in the
BabylonParser
, causing fatal JS errors in applications that suffer these bugs. Defensively coding this parser to check for existence before attempting to access properties ensures no JS fatal errors.Test plan
BabylonParser tests still green post-changes; however, fixes my specific issues while using jest-community/vscode-jest#92 which uses
jest-editor-support
.