Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli notify not taking precedence #3340

Merged
merged 2 commits into from
Apr 21, 2017

Conversation

liubinyi
Copy link
Contributor

@liubinyi liubinyi commented Apr 21, 2017

Fix issue #3335.

CLI notify option not taking precedence over config option

@codecov-io
Copy link

Codecov Report

Merging #3340 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3340   +/-   ##
=======================================
  Coverage   65.07%   65.07%           
=======================================
  Files         178      178           
  Lines        6539     6539           
  Branches        4        4           
=======================================
  Hits         4255     4255           
  Misses       2283     2283           
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-config/src/setFromArgv.js 2.43% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554e884...065ac6f. Read the comment docs.

@cpojer cpojer merged commit 6f47aa3 into jestjs:master Apr 21, 2017
@cpojer
Copy link
Member

cpojer commented Apr 21, 2017

Thank you!

@danny-andrews
Copy link

Wow, that was fast! Thanks @liubinyi!

skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants