-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Config
type.
#3366
Remove Config
type.
#3366
Conversation
@@ -1,104 +0,0 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this file in a later commit (not yet sent out) already where I fix up how updateConfig works. At that point, we won't be passing updateConfig to ProjectConfig any more and this test will not be useful any more. I have new tests that make sure this works in a follow-up.
Right now, the return value of |
Codecov Report
@@ Coverage Diff @@
## master #3366 +/- ##
==========================================
- Coverage 64.89% 64.09% -0.81%
==========================================
Files 176 176
Lines 6521 6526 +5
Branches 4 4
==========================================
- Hits 4232 4183 -49
- Misses 2288 2342 +54
Partials 1 1
Continue to review full report at Codecov.
|
In the interest of time, I'm gonna go forward with this. If there are any concerns with this direction, please let me know and I'll revert or fix. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Next diff in the sea of diffs to split up configs. This removes the Config type completely. I have follow-ups where I start to pull things apart properly and remove fields from either ProjectConfig or GlobalConfig.
Test plan
jest