Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Config type. #3366

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Remove Config type. #3366

merged 1 commit into from
Apr 27, 2017

Conversation

cpojer
Copy link
Member

@cpojer cpojer commented Apr 25, 2017

Summary

Next diff in the sea of diffs to split up configs. This removes the Config type completely. I have follow-ups where I start to pull things apart properly and remove fields from either ProjectConfig or GlobalConfig.

Test plan

jest

@@ -1,104 +0,0 @@
/**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this file in a later commit (not yet sent out) already where I fix up how updateConfig works. At that point, we won't be passing updateConfig to ProjectConfig any more and this test will not be useful any more. I have new tests that make sure this works in a follow-up.

@cpojer
Copy link
Member Author

cpojer commented Apr 25, 2017

Right now, the return value of normalize returns an "options" object which is GlobalConfig & ProjectConfig (basically what Config was). We should change this over time and we'll have to fix up many tests that rely on this (see the rename of .config to options). I made the minimal changes to make the tests work and it seems to be good enough for now.

@codecov-io
Copy link

codecov-io commented Apr 25, 2017

Codecov Report

Merging #3366 into master will decrease coverage by 0.8%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3366      +/-   ##
==========================================
- Coverage   64.89%   64.09%   -0.81%     
==========================================
  Files         176      176              
  Lines        6521     6526       +5     
  Branches        4        4              
==========================================
- Hits         4232     4183      -49     
- Misses       2288     2342      +54     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-config/src/constants.js 100% <ø> (ø) ⬆️
packages/jest-config/src/normalize.js 89.54% <ø> (ø) ⬆️
packages/jest-jasmine2/src/setup-jest-globals.js 0% <ø> (ø) ⬆️
packages/jest-environment-node/src/index.js 69.56% <ø> (ø) ⬆️
packages/jest-environment-jsdom/src/index.js 0% <ø> (ø) ⬆️
packages/jest-jasmine2/src/index.js 0% <0%> (ø) ⬆️
packages/jest-jasmine2/src/jest-expect.js 0% <0%> (ø) ⬆️
packages/jest-config/src/index.js 26.08% <33.33%> (ø) ⬆️
packages/jest-cli/src/runJest.js 0% <0%> (-59.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 005ac8c...24944e6. Read the comment docs.

@cpojer
Copy link
Member Author

cpojer commented Apr 27, 2017

In the interest of time, I'm gonna go forward with this. If there are any concerns with this direction, please let me know and I'll revert or fix.

@cpojer cpojer merged commit 008a559 into jestjs:master Apr 27, 2017
@cpojer cpojer deleted the rm-config branch May 4, 2017 15:44
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants