-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix snapshot serializer require, restructure pretty-format. #3399
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3399 +/- ##
==========================================
- Coverage 64.27% 64.16% -0.11%
==========================================
Files 176 176
Lines 6538 6530 -8
Branches 4 4
==========================================
- Hits 4202 4190 -12
- Misses 2335 2339 +4
Partials 1 1
Continue to review full report at Codecov.
|
036586d
to
413b752
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
module.exports = { | ||
process(src, filename, config, options) { | ||
if (/bar.js$/.test(filename)) { | ||
return `${src};\module.exports = createPlugin('bar');`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the backslash (\
) is a little confusing here at the first look. Can we remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That was a bug.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #3284 by not bypassing the user defined transform pipeline.
This also enables proper typing for pretty-format plugins within the Jest repo and stops reaching into
build
files, which Jest should never do, by exporting the plugins directly.Test plan
jest