Parallel coverage #3407
Parallel coverage #3407
Conversation
This changes the coverage reporter's _addUntestedFiles function to be parallelized. This speeds up coverage collection on machines with multiple cores for test suites with many untested files.
aaronabramov
force-pushed
the
parallel-coverage
branch
from
40905db
to
813cdc9
Compare
Codecov Report
@@ Coverage Diff @@
## master #3407 +/- ##
==========================================
- Coverage 64.27% 64.24% -0.03%
==========================================
Files 176 177 +1
Lines 6538 6561 +23
Branches 4 4
==========================================
+ Hits 4202 4215 +13
- Misses 2335 2345 +10
Partials 1 1
Continue to review full report at Codecov.
|
| ); | ||
| process.exit(1); | ||
| const exit = () => process.exit(1); | ||
| this._dispatcher |
There was a problem hiding this comment.
This being async will not work as it will keep running tests until the reporters are done. You need to wait on the result of _bailIfNeeded and return Promise.resolve() otherwise. I'll send a fix.
| if (result.sourceMapPath) { | ||
| this._sourceMapStore.registerURL(path, result.sourceMapPath); | ||
|
|
||
| const farm = workerFarm( |
There was a problem hiding this comment.
This needs to be able to run in band if maxWorkers is <=1.
* [CoverageReporter] Parallelize instrumentation of untested files. This changes the coverage reporter's _addUntestedFiles function to be parallelized. This speeds up coverage collection on machines with multiple cores for test suites with many untested files. * Parallel coverage (resolve conflicts)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
based on #3309
i had to resolve some conflicts (multi runner/config splitting touched the same files)