Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colors for expected/stored snapshot message #3702

Merged
merged 1 commit into from
May 31, 2017
Merged

Fix colors for expected/stored snapshot message #3702

merged 1 commit into from
May 31, 2017

Conversation

duailibe
Copy link
Contributor

Summary

Jest colors (expected/stored in snapshot) in single line strings in snapshots were reversed:

Before After
Before After

Test plan

There's a repro case in http://github.com/duailibe/jest-snapshot-colors

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I just bumped into this yesterday.

@cpojer cpojer merged commit c368a59 into jestjs:master May 31, 2017
@cpojer
Copy link
Member

cpojer commented May 31, 2017

Woah, when did that flip happen. Mega oops.

@duailibe duailibe deleted the snapshot-colors-fix branch May 31, 2017 20:35
@codecov-io
Copy link

Codecov Report

Merging #3702 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3702      +/-   ##
==========================================
+ Coverage   62.65%   62.72%   +0.07%     
==========================================
  Files         183      183              
  Lines        6707     6701       -6     
  Branches        6        6              
==========================================
+ Hits         4202     4203       +1     
+ Misses       2502     2495       -7     
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-snapshot/src/index.js 50% <ø> (ø) ⬆️
packages/jest-snapshot/src/utils.js 100% <0%> (ø) ⬆️
packages/jest-jasmine2/src/jasmine/SpyRegistry.js 0% <0%> (ø) ⬆️
packages/jest-util/src/Console.js 0% <0%> (ø) ⬆️
...es/pretty-format/src/plugins/lib/printImmutable.js 100% <0%> (ø) ⬆️
packages/jest-jasmine2/src/jest-expect.js 0% <0%> (ø) ⬆️
packages/jest-haste-map/src/index.js 93.43% <0%> (+0.02%) ⬆️
packages/jest-cli/src/runTest.js 15.55% <0%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f75f885...e8b10db. Read the comment docs.

tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants