fix bug when setTimeout is mocked #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3769 +/- ##
=========================================
- Coverage 59.86% 59.8% -0.06%
=========================================
Files 191 191
Lines 7007 7014 +7
Branches 6 6
=========================================
Hits 4195 4195
- Misses 2809 2816 +7
Partials 3 3
Continue to review full report at Codecov.
|
cpojer
reviewed
Jun 9, 2017
| .then(() => { | ||
| // If timeout is not cleared/unrefed the node process won't exit until | ||
| // it's resolved. | ||
| timeoutID.unref && timeoutID.unref(); |
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tho things:
setTimeoutare shared with the test and could be mocked (which will mess up circus internals). This is a quick fix to reference the real values before any test files are imported so nothing can mess with them. (i have a task to move circus to the outer scope, it'll take a while though, cause the code that does this right now is very complex)