Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming files names WIP Addresses #3771 #3798

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Renaming files names WIP Addresses #3771 #3798

merged 1 commit into from
Jun 23, 2017

Conversation

anilreddykatta
Copy link
Contributor

@anilreddykatta anilreddykatta commented Jun 12, 2017

Summary

Renaming files to make it consistent across entire repo. Addresses #3771. This is Work In Progress
Test plan

@codecov-io
Copy link

codecov-io commented Jun 21, 2017

Codecov Report

Merging #3798 into master will not change coverage.
The diff coverage is 13.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3798   +/-   ##
=======================================
  Coverage   58.07%   58.07%           
=======================================
  Files         195      195           
  Lines        6734     6734           
  Branches        6        6           
=======================================
  Hits         3911     3911           
  Misses       2820     2820           
  Partials        3        3
Impacted Files Coverage Δ
...ages/jest-config/src/reporter_validation_errors.js 33.33% <ø> (ø)
packages/jest-haste-map/src/haste_fs.js 52.63% <ø> (ø)
packages/jest-jasmine2/src/tree_processor.js 0% <ø> (ø)
...kages/jest-circus/src/format_node_assert_errors.js 0% <ø> (ø)
...eslint-plugin-jest/src/rules/no_identical_title.js 100% <ø> (ø)
packages/jest-editor-support/src/process.js 7.69% <ø> (ø)
...s/jest-haste-map/src/lib/get_platform_extension.js 100% <ø> (ø)
packages/jest-jasmine2/src/queue_runner.js 100% <ø> (ø)
packages/jest-jasmine2/src/jasmine/call_tracker.js 0% <ø> (ø)
...circus/src/legacy_code_todo_rewrite/jest_expect.js 0% <ø> (ø)
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b0a07...6cb886b. Read the comment docs.

@anilreddykatta
Copy link
Contributor Author

@aaronabramov, @cpojer, @thymikee Please, provide your comments on this PR. As this will renaming most of the files, it would be really helpful for initial comments/suggestions so that I can act and get it merged!

  • I renamed almost all the packages, except jest-cli, which is causing more test case failures. I will finish this too by this week.
  • Some files like Console.js in jest-utils when renamed to lower case it is failing some test cases throwing it cannot resolve the module. Very weird, as I could see the file name in the exact same directory it is looking in
  • Higher level package directories like jest, jest-cli are kep intact as they are already in lower case. Unless snake case is jest_cli is what we are looking for packages.
  • Directories, and file names are named in lower snake case blah_blah.js/blah_blah.test.js. Directories inside packages are also being named on these lines

@aaronabramov
Copy link
Contributor

this is great! I tested it locally and it seems to be working fine.
thank you so much for working on this @anilreddykatta!
i'll file a couple of followups to finish renaming and enforce the new naming convention

@aaronabramov aaronabramov merged commit 21a2b7a into jestjs:master Jun 23, 2017
@anilreddykatta
Copy link
Contributor Author

@aaronabramov Sure. I will work on it.!

tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants