Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log stack when reporting errors in jest-runtime #3833

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Log stack when reporting errors in jest-runtime #3833

merged 1 commit into from
Jun 15, 2017

Conversation

sebmck
Copy link

@sebmck sebmck commented Jun 15, 2017

Summary

Without this change console.error will only log the message property and the stack will look like this:

Error: Cannot find module '../build/Release/pty.node' from 'pty.js'

Makes it pretty impossible to debug where the errors are coming from.

Test plan

Made the change locally and it worked fine.

@cpojer cpojer merged commit d7f2a71 into jestjs:master Jun 15, 2017
@sebmck sebmck deleted the patch-1 branch June 15, 2017 10:30
@codecov-io
Copy link

Codecov Report

Merging #3833 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3833   +/-   ##
=======================================
  Coverage   57.63%   57.63%           
=======================================
  Files         194      194           
  Lines        6782     6782           
  Branches        6        6           
=======================================
  Hits         3909     3909           
  Misses       2870     2870           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79eed25...4384c76. Read the comment docs.

tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants