Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to toHaveProperty docs #3878

Merged
merged 2 commits into from
Jun 22, 2017
Merged

Conversation

RobertJGabriel
Copy link
Contributor

Summary

Hey was just learning about jest (great btw, late to the part) but noticed these small things. I might be wrong but looks like small grammar or extra , :) Sorry If I miss understood

Test plan

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@RobertJGabriel
Copy link
Contributor Author

CLA signed.

@codecov-io
Copy link

codecov-io commented Jun 22, 2017

Codecov Report

Merging #3878 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3878   +/-   ##
=======================================
  Coverage   57.65%   57.65%           
=======================================
  Files         195      195           
  Lines        6782     6782           
  Branches        6        6           
=======================================
  Hits         3910     3910           
  Misses       2869     2869           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e8f282...67a3a05. Read the comment docs.

@aaronabramov
Copy link
Contributor

i'm surprised no one noticed it before! thank you!
i added trailing commas back, since they are a part of our style guide 🙂

@aaronabramov aaronabramov merged commit e9b045f into jestjs:master Jun 22, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* Hopefully, small fixes

* Update ExpectAPI.md
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants