Avoid writing to stdout in default reporter if --json is enabled. Fixes #3941 #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3945 +/- ##
==========================================
- Coverage 58.06% 58.01% -0.06%
==========================================
Files 196 196
Lines 6758 6764 +6
Branches 6 6
==========================================
Hits 3924 3924
- Misses 2831 2837 +6
Partials 3 3
Continue to review full report at Codecov.
|
cpojer
reviewed
Jun 30, 2017
| // This is to avoid conflicts between random output and status text | ||
| this._clearStatus(); | ||
| originalWrite.call(stream, string); | ||
| string && originalWrite.call(stream, string); |
cpojer
reviewed
Jun 30, 2017
| const testCase = { | ||
| context: {config: {rootDir: '/'}}, | ||
| path: '/foo', | ||
| duration: 0, |
There was a problem hiding this comment.
please sort keys alphabetically.
cpojer
reviewed
Jun 30, 2017
| duration: 0, | ||
| }; | ||
| const testResult = { | ||
| testFilePath: '/foo' |
cpojer
reviewed
Jun 30, 2017
| }; | ||
|
|
||
| let DefaultReporter; | ||
| let stdout, stderr; |
There was a problem hiding this comment.
nit: only one var definition per let.
cpojer
reviewed
Jun 30, 2017
| expect(stdout).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| test('when using stderr as output, no stdout call is done', () => { |
|
Sweet! Please run |
mjesun
added a commit
that referenced
this pull request
Jun 30, 2017
…led. Fixes #3941" (#3951) * Revert "fix typo in snapshot testing documentation (#3948)" This reverts commit d6998c2. * Revert "Fix linting (#3946)" This reverts commit 9426521. * Revert "Avoid writing to stdout in default reporter if --json is enabled. Fixes #3941 (#3945)" This reverts commit 68d747d.
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
…led. Fixes jestjs#3941" (jestjs#3951) * Revert "fix typo in snapshot testing documentation (jestjs#3948)" This reverts commit d6998c2. * Revert "Fix linting (jestjs#3946)" This reverts commit 9426521. * Revert "Avoid writing to stdout in default reporter if --json is enabled. Fixes jestjs#3941 (jestjs#3945)" This reverts commit 68d747d.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check #3941 for more details.