Check whether we should output to stdout or stderr #3953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to another two changes deployed this morning: #3945 and #3946. These two had to be rolled back because they were causing issues in CI, however they were working locally.
The cause of the breakage in CI was due to the fact that the
is-ci
module was not being mocked. Since CI sessions are considered non-interactive, the reporter was not outputting anything and the test failed. After adding a mock to the module (jest.mock('is-ci', () => false)
) tests are passing now.Code for the reporter itself has not been changed when comparing it with the two earlier PRs, so the release done in-between (
jest@20.1-alpha.3
) is safe in that sense.