changed files eager loading #3979
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3979 +/- ##
=========================================
+ Coverage 59.87% 59.9% +0.02%
=========================================
Files 196 197 +1
Lines 6794 6804 +10
Branches 6 6
=========================================
+ Hits 4068 4076 +8
- Misses 2723 2725 +2
Partials 3 3
Continue to review full report at Codecov.
|
| lastCommit: testSelectionConfig.lastCommit, | ||
| }); | ||
| if (!changedFilesPromise) { | ||
| throw new Error('This promise must be presen when running with -o'); |
| lastCommit: testSelectionConfig.lastCommit, | ||
| }); | ||
| if (!changedFilesPromise) { | ||
| throw new Error('This promise must be present when running with -o.'); |
There was a problem hiding this comment.
Should we change the error message to something like "'A Git or Mercurial repository must be present when running with -o."? So that it gives some info to the user
There was a problem hiding this comment.
this is pretty much an invariant and should never throw. I only put it in there, because the promise is generated early in the flow and argv is modified during the flow. So potentially we can cause inconsistent state (ran with -o, but promise is not passed).
This error here just for catching potential bugs early :)
| @@ -95,6 +97,7 @@ describe('Watch mode flows', () => { | |||
| pipe, | |||
| new TestWatcher({isWatchMode: true}), | |||
There was a problem hiding this comment.
Should we consider changing the signature of run_jest to an object of all this options instead of positional arguments?
There was a problem hiding this comment.
it's on my plan! bun not in this PR :)
I already started refactoring the CLI flow
* changed files eager loading * Update search_source.js
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
should solve the performance regression in www.
I'm not a fan of passing this promise all the way down, but there isn't really a nice way of doing this yet
cc @rogeliog can you look at the watch stuff? i wanna make sure i didn't break anything accidentally