-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move maxWorkers
to globalConfig
#4005
move maxWorkers
to globalConfig
#4005
Conversation
ecbe48d
to
6a3d1ae
Compare
Make sure CI passes. |
eb42f02
to
1500617
Compare
packages/jest-cli/src/test_runner.js
Outdated
@@ -205,6 +204,7 @@ class TestRunner { | |||
} | |||
|
|||
this._dispatcher.onTestStart(test); | |||
console.error(test.path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i just added it to debug appveyor :(
We can get rid of |
@thymikee oh.. that's a good catch, there's the whole reporters options object that can be removed too. Strange that flow didn't catch it |
I would be surprised if it had caught that 😄. Doesn't seem to be trivial to infer (programatically) that second argument is unnecessary, because it can be calculated from first one. Warnings like that would be gold though. |
1500617
to
918e75d
Compare
918e75d
to
5a57c1a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4005 +/- ##
==========================================
+ Coverage 60.26% 60.28% +0.02%
==========================================
Files 196 196
Lines 6765 6764 -1
Branches 6 6
==========================================
+ Hits 4077 4078 +1
+ Misses 2685 2683 -2
Partials 3 3
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.